Test leaving one2one subconversations#4160
Merged
pcapriotti merged 5 commits intodevelopfrom Jul 22, 2024
Merged
Conversation
8a1bba5 to
85a403a
Compare
Instead of using a hardcoded removal key, get the removal key from the correct backend using its public API.
b4daa8d to
cd88b5a
Compare
stefanwire
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at reproducing a bug reported by the client teams.
Some initial attempt at using distinct removal keys for the various test backends is at the branch pcapriotti/distinct-removal-keys.
https://wearezeta.atlassian.net/browse/WPB-10205
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d