Skip to content

Stop leaking ES error info.#4153

Merged
battermann merged 3 commits intodevelopfrom
wpb-6865/leaking-es-error-info
Jul 19, 2024
Merged

Stop leaking ES error info.#4153
battermann merged 3 commits intodevelopfrom
wpb-6865/leaking-es-error-info

Conversation

@elland
Copy link
Contributor

@elland elland commented Jul 15, 2024

https://wearezeta.atlassian.net/browse/WPB-6865

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Jul 15, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 15, 2024
@battermann battermann force-pushed the wpb-6865/leaking-es-error-info branch from 6bdbb3d to 42769ec Compare July 18, 2024 15:01
@battermann battermann marked this pull request as ready for review July 18, 2024 15:04
@battermann
Copy link
Contributor

I have manually reproduced and tested that the change works.

This implementation removes any exception message from the errors returned from wire-server when there is an internal error, not only the one mentioned in the ticket. These internal errors are always logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants