Skip to content

Introduce PropertySubsystem#4148

Merged
akshaymankar merged 10 commits intodevelopfrom
properties-subsystem
Jul 24, 2024
Merged

Introduce PropertySubsystem#4148
akshaymankar merged 10 commits intodevelopfrom
properties-subsystem

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 15, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-10087

Also contains:

  1. bugfix: Allow setting existing properties even if we have max properties.
  2. bugfix: Return HTTP 400 instead of 500 when property key is not printable ASCII.
  3. tests: Migrate property integration tests to the new integration suite.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jul 15, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 15, 2024
@akshaymankar akshaymankar force-pushed the properties-subsystem branch from a2efe6c to 3f411e8 Compare July 22, 2024 09:43
@akshaymankar akshaymankar force-pushed the properties-subsystem branch 5 times, most recently from da8ff49 to af8a3f5 Compare July 23, 2024 09:13
@akshaymankar akshaymankar force-pushed the properties-subsystem branch 3 times, most recently from f606df1 to 5640115 Compare July 23, 2024 16:58
@akshaymankar akshaymankar marked this pull request as ready for review July 23, 2024 16:59
@akshaymankar akshaymankar force-pushed the properties-subsystem branch from 5640115 to 842b7b3 Compare July 23, 2024 17:00
@mdimjasevic mdimjasevic self-requested a review July 24, 2024 06:55
pcapriotti
pcapriotti approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mdimjasevic mdimjasevic removed their request for review July 24, 2024 07:13
@akshaymankar akshaymankar merged commit a9e8c5f into develop Jul 24, 2024
@akshaymankar akshaymankar deleted the properties-subsystem branch July 24, 2024 08:51
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
@zebot zebot mentioned this pull request Oct 23, 2024
Closed
This was referenced Oct 25, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees

No one assigned

Labels

echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akshaymankar @pcapriotti @zebot