Skip to content

Concurrently fetch user profiles from the DB#4140

Merged
akshaymankar merged 2 commits intodevelopfrom
optimize-list-users
Jul 15, 2024
Merged

Concurrently fetch user profiles from the DB#4140
akshaymankar merged 2 commits intodevelopfrom
optimize-list-users

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 11, 2024

The endpoint typically takes 0.5-1 second to respond with ~200 users. It is called by the webapp on boot for every known user (not sure why) making UX very slow.

Here is a chart from prod showing response times for this particular endpoint:

image

Local tests show about 70% reduction in response time.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 11, 2024
@akshaymankar akshaymankar marked this pull request as ready for review July 11, 2024 05:55
@akshaymankar akshaymankar force-pushed the optimize-list-users branch from a639f6f to 9f860ef Compare July 15, 2024 06:30
@akshaymankar akshaymankar changed the title Optimize POST /list-users Concurrently fetch user profiles from the DB Jul 15, 2024
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of magic numbers but fine by me.

@akshaymankar akshaymankar merged commit dab374b into develop Jul 15, 2024
@akshaymankar akshaymankar deleted the optimize-list-users branch July 15, 2024 07:12
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants