Concurrently fetch user profiles from the DB#4140
Merged
akshaymankar merged 2 commits intodevelopfrom Jul 15, 2024
Merged
Conversation
akshaymankar
commented
Jul 11, 2024
a639f6f to
9f860ef
Compare
POST /list-users
elland
approved these changes
Jul 15, 2024
Contributor
elland
left a comment
There was a problem hiding this comment.
Not a fan of magic numbers but fine by me.
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint typically takes 0.5-1 second to respond with ~200 users. It is called by the webapp on boot for every known user (not sure why) making UX very slow.
Here is a chart from prod showing response times for this particular endpoint:
Local tests show about 70% reduction in response time.
Checklist
changelog.d