Fix hardcoded use of ciphersuite 1 when switching to mixed protocol#4048
Merged
stefanwire merged 4 commits intodevelopfrom May 15, 2024
Merged
Fix hardcoded use of ciphersuite 1 when switching to mixed protocol#4048stefanwire merged 4 commits intodevelopfrom
stefanwire merged 4 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
mdimjasevic
approved these changes
May 15, 2024
|
stefanwire
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ciphersuite 1 was still used as the hardcoded ciphersuite for the newly created MLS group after a proteus → mixed transition. This made it impossible to use other ciphersuites for the MLS part of a mixed conversation.
https://wearezeta.atlassian.net/browse/WPB-9142
Checklist
changelog.d