Skip to content

Generalise catchErrors middleware#4037

Merged
pcapriotti merged 2 commits intodevelopfrom
pcapriotti/fix-federator-request-id
May 6, 2024
Merged

Generalise catchErrors middleware#4037
pcapriotti merged 2 commits intodevelopfrom
pcapriotti/fix-federator-request-id

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented May 3, 2024

Make it possible for services to specify a different way to extract the ID of a request. For federator requests, the ID is in a different header, so the catchErrors middleware needs to be aware of the difference when logging.

Related to: https://wearezeta.atlassian.net/browse/WPB-7161

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 3, 2024
@pcapriotti pcapriotti marked this pull request as ready for review May 6, 2024 07:21
@pcapriotti pcapriotti merged commit 40445b5 into develop May 6, 2024
@pcapriotti pcapriotti deleted the pcapriotti/fix-federator-request-id branch May 6, 2024 07:21
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants