Merged
Conversation
2 tasks
zebot
added
the
ok-to-test
mdimjasevic
reviewed
Apr 25, 2024
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
I am still reviewing, but maybe you wanted to know of this TODO left in the code before I am done with the whole PR.
Contributor
|
Would it make sense to rename the |
mdimjasevic
approved these changes
Apr 25, 2024
pcapriotti
force-pushed
the
pcapriotti/servantify-galley-internal
branch
2 times, most recently
from
79e28fc to
f24f0c2
Compare
Removing wai-routing's Raw endpoint in galley's servant tree changes the error responses for endpoints with recoverable failures (i.e. `Fail` route results in Servant). This commit restores compatibility by adding a fallback endpoint that always responds with 404.
pcapriotti
force-pushed
the
pcapriotti/servantify-galley-internal
branch
from
f24f0c2 to
e6b17ae
Compare
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servantify internal endpoints and one final public endpoint. This supersedes #3997.
https://wearezeta.atlassian.net/browse/WPB-1223
Checklist
changelog.d