Skip to content

[chore] Move Cql instances to avoid orphans#4005

Merged
elland merged 7 commits intodevelopfrom
wpb5990-move-cql-instances
Apr 17, 2024
Merged

[chore] Move Cql instances to avoid orphans#4005
elland merged 7 commits intodevelopfrom
wpb5990-move-cql-instances

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Apr 16, 2024

https://wearezeta.atlassian.net/browse/WPB-5990

this is not only needed for ongoing work in wire-subsystems, but it also showed that we had a lot of duplicate instances in our code base, and some of them didn't even agree on semantics. this pull request fixes some of that.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 16, 2024
@fisx fisx marked this pull request as ready for review April 17, 2024 10:26
@elland elland changed the title Move around Cql instances. [chore] Move Cql instances to avoid orphans Apr 17, 2024
@elland elland force-pushed the wpb5990-move-cql-instances branch from fa32439 to 4dfd237 Compare April 17, 2024 12:58
@elland elland force-pushed the wpb5990-move-cql-instances branch from ffe67a7 to eef48b7 Compare April 17, 2024 13:54
@elland elland merged commit a6dff20 into develop Apr 17, 2024
@elland elland deleted the wpb5990-move-cql-instances branch April 17, 2024 14:37
@echoes-hq echoes-hq bot added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants