Skip to content

[chore] Port 2FA tests#3986

Merged
battermann merged 8 commits intodevelopfrom
battermann/port-2fa-tests
Apr 9, 2024
Merged

[chore] Port 2FA tests#3986
battermann merged 8 commits intodevelopfrom
battermann/port-2fa-tests

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 9, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann force-pushed the battermann/port-2fa-tests branch from 473acb9 to 681a7d4 Compare April 9, 2024 07:39
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 9, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the old test, we were checking the json content as well, i think that was useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find it, can you point me to it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i was reading it wrong. all good!

@battermann battermann force-pushed the battermann/port-2fa-tests branch from 6bff9e0 to 53efc14 Compare April 9, 2024 12:58
@battermann battermann merged commit e4020b8 into develop Apr 9, 2024
@battermann battermann deleted the battermann/port-2fa-tests branch April 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants