Skip to content

early exit when deleting already gone client#3982

Merged
stefanwire merged 2 commits intoq1-2024from
sb/logeffects
Apr 9, 2024
Merged

early exit when deleting already gone client#3982
stefanwire merged 2 commits intoq1-2024from
sb/logeffects

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Apr 5, 2024

Ticket: https://wearezeta.atlassian.net/browse/WPB-7416

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@stefanwire stefanwire requested a review from supersven April 5, 2024 10:31
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 5, 2024
@stefanwire stefanwire changed the title add debug logs for all Cassanndra effects early exit when deleting already gone client Apr 8, 2024
@stefanwire stefanwire requested a review from supersven April 8, 2024 15:55
- in Galley's internal `DELETE /i/client/:clientid`
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamping for Zulu (The PR to master has already been approved: #3985)

@mdimjasevic
Copy link
Contributor

Could this debugging effort be merged to a non-release branch and then deploy that branch to environments of interest for debugging?

@stefanwire
Copy link
Contributor Author

Could this debugging effort be merged to a non-release branch and then deploy that branch to environments of interest for debugging?

Following the discussion on Backend, I will merge the logs. They should not be viewed as efforts to debug a single issue, but rather seen as an effort to debug future issues on live systems. This should remain in place until we settle on a better way to achieve the same or better observability of our services.

@stefanwire stefanwire merged commit c829737 into q1-2024 Apr 9, 2024
@stefanwire stefanwire deleted the sb/logeffects branch April 9, 2024 10:05
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants