Merged
Conversation
pcapriotti
force-pushed
the
pcapriotti/new-mls-ciphersuites
branch
from
e934b61 to
36b32d8
Compare
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/new-mls-ciphersuites
branch
from
5345f8f to
d90d76c
Compare
pcapriotti
force-pushed
the
pcapriotti/new-mls-ciphersuites
branch
4 times, most recently
from
7e39139 to
9a43d6f
Compare
The JSON files were generated using the code before this refactoring
pcapriotti
force-pushed
the
pcapriotti/new-mls-ciphersuites
branch
from
89e05c7 to
d670a4b
Compare
pcapriotti
force-pushed
the
pcapriotti/new-mls-ciphersuites
branch
from
81e3bee to
ec3377e
Compare
stefanwire
approved these changes
Apr 24, 2024
pcapriotti
added a commit
that referenced
this pull request
Apr 25, 2024
* Add one ECDSA ciphersuite * Fix ECDSA signature decoding * Create test clients using correct signature scheme * Fix unsupported ciphersuite test * Create one mls-test-cli store per signature scheme * Add MLS_256_DHKEMP384_AES256GCM_SHA384_P384 * Add MLS_256_DHKEMP521_AES256GCM_SHA512_P521 * Fix secp384 signature verification * Fix x509 credential validation * Update mls-test-cli to 0.11 * Turn TODO into FUTUREWORK * Add failing test showing incorrect backend signature * Store private keys for other signature schemes * Parse ECDSA private keys * Encode ECDSA signatures * Pass removal key correctly to mls-test-cli * MLSKeys: Move from maps to records for config and public key endpoint * Adapt to MLSKeys changes in galley * Move GET /mls/public-keys test to new integration suite * Remove SignaturePurpose type * Add golden tests for MLSKeys The JSON files were generated using the code before this refactoring * Document new removal key config options * Test public key endpoint when MLS is not enabled * Fix galley configmap * Make withCiphersuite exception-safe --------- Co-authored-by: Akshay Mankar <akshay@wire.com>
2 tasks
pcapriotti
added a commit
that referenced
this pull request
Apr 26, 2024
* New MLS ciphersuites (#3964) * Add one ECDSA ciphersuite * Fix ECDSA signature decoding * Create test clients using correct signature scheme * Fix unsupported ciphersuite test * Create one mls-test-cli store per signature scheme * Add MLS_256_DHKEMP384_AES256GCM_SHA384_P384 * Add MLS_256_DHKEMP521_AES256GCM_SHA512_P521 * Fix secp384 signature verification * Fix x509 credential validation * Update mls-test-cli to 0.11 * Turn TODO into FUTUREWORK * Add failing test showing incorrect backend signature * Store private keys for other signature schemes * Parse ECDSA private keys * Encode ECDSA signatures * Pass removal key correctly to mls-test-cli * MLSKeys: Move from maps to records for config and public key endpoint * Adapt to MLSKeys changes in galley * Move GET /mls/public-keys test to new integration suite * Remove SignaturePurpose type * Add golden tests for MLSKeys The JSON files were generated using the code before this refactoring * Document new removal key config options * Test public key endpoint when MLS is not enabled * Fix galley configmap * Make withCiphersuite exception-safe
echoes-hq
bot
added
echoes: technical-roadmap/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for more MLS ciphersuites:
The latter is not yet supported in openmls, so it is currently untested.
https://wearezeta.atlassian.net/browse/WPB-7169
Checklist
changelog.d