Skip to content

smallstep-accomp: Resolve proxy target on request (#3946)#3947

Merged
supersven merged 1 commit intodevelopfrom
develop-use-resolver-to-handle-offline-proxy-targets
Mar 14, 2024
Merged

smallstep-accomp: Resolve proxy target on request (#3946)#3947
supersven merged 1 commit intodevelopfrom
develop-use-resolver-to-handle-offline-proxy-targets

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Mar 13, 2024

Usually, proxy targets are resolved when nginx is started. This can lead to strange behavior if the target either doesn't exist (yet) or the DNS entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the lookup(s) while nginx is running. The default behavior of the resolver directive is to update the target according to its TTL in the configured DNS server.

N.B. this a cherry-pick / backport of #3946
Ticket: https://wearezeta.atlassian.net/browse/WPB-6822

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

Usually, proxy targets are resolved when nginx is started. This can lead
to strange behavior if the target either doesn't exist (yet) or the DNS
entry changes while nginx is running.

This little trick with the indirection via a variable should trigger the
lookup(s) while nginx is running. The default behavior of the `resolver`
directive is to update the target according to its TTL in the configured
DNS server.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 13, 2024
Copy link
Contributor

@jschumacher-wire jschumacher-wire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@supersven supersven merged commit ba0d7f1 into develop Mar 14, 2024
@supersven supersven deleted the develop-use-resolver-to-handle-offline-proxy-targets branch March 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants