Skip to content

Credential Provisioning for SFT authentication#3915

Merged
stefanwire merged 12 commits intodevelopfrom
sb/sft-credentials
Apr 10, 2024
Merged

Credential Provisioning for SFT authentication#3915
stefanwire merged 12 commits intodevelopfrom
sb/sft-credentials

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Mar 1, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-227

Checklist

  • create additional configuration for brig
  • create username and credential fields in sft_servers_all
  • rate-limit new credentials by user
  • include is_federating
  • switch to Z-Client header
  • integration test
  • API versioning
  • use multiSFT for is_federating
  • migrate integration tests to /integration
  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 1, 2024
@stefanwire stefanwire force-pushed the sb/sft-credentials branch 2 times, most recently from b9a526c to a788194 Compare March 4, 2024 16:20
@stefanwire stefanwire removed the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 4, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 13, 2024
@stefanwire stefanwire force-pushed the sb/sft-credentials branch 5 times, most recently from 7d3c6b7 to 4fa3338 Compare March 19, 2024 13:28
@stefanwire stefanwire force-pushed the sb/sft-credentials branch 12 times, most recently from e727c70 to 2adf177 Compare March 27, 2024 15:46
@stefanwire stefanwire marked this pull request as ready for review March 27, 2024 15:52
@stefanwire stefanwire force-pushed the sb/sft-credentials branch 2 times, most recently from 1378326 to e0e303e Compare April 3, 2024 15:26
@stefanwire stefanwire changed the base branch from develop to sb/revert3929 April 3, 2024 15:27
Base automatically changed from sb/revert3929 to develop April 4, 2024 07:20
@stefanwire stefanwire force-pushed the sb/sft-credentials branch from e0e303e to 0a70d58 Compare April 4, 2024 07:33
akshaymankar
akshaymankar reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the transaction stuff because I don't see why the credentials needs to be stored at all.

@stefanwire stefanwire force-pushed the sb/sft-credentials branch 3 times, most recently from 1c8cf52 to 247da65 Compare April 9, 2024 13:37
@stefanwire
Copy link
Contributor Author

stefanwire commented Apr 9, 2024

I didn't look at the transaction stuff because I don't see why the credentials needs to be stored at all.

Removed after discussion.

@stefanwire stefanwire force-pushed the sb/sft-credentials branch from 247da65 to f74a574 Compare April 9, 2024 13:44
@stefanwire stefanwire requested a review from akshaymankar April 10, 2024 06:24
akshaymankar
akshaymankar reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved rubber stamp in green tilted by 45 deg

@stefanwire stefanwire merged commit 057af45 into develop Apr 10, 2024
@stefanwire stefanwire deleted the sb/sft-credentials branch April 10, 2024 07:59
@elland elland mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Jun 27, 2024
akshaymankar added a commit that referenced this pull request Aug 8, 2024
@akshaymankar
integration: setField and modifyField create selector paths if they d…
abda00c 
…on't exist

Partially cherry-picked from #3915
akshaymankar added a commit that referenced this pull request Aug 8, 2024
@akshaymankar @battermann
Backport #4063 (#4185)
ebf3320 
* Backport #4063

And fix couple of warnings caused by previous commits not being cherry-picked.

* integration: Fix order of arguments for getTeamFeature

* integration: setField and modifyField create selector paths if they don't exist

Partially cherry-picked from #3915

---------

Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees

No one assigned

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanwire @akshaymankar @zebot