WPB-6577 Fix user creation conflict in SCIM#3914
Merged
battermann merged 11 commits intodevelopfrom Mar 8, 2024
Merged
Conversation
zebot
added
the
ok-to-test
battermann
changed the title
battermann
force-pushed
the
WPB-6577-on-prem-duplicate-user-creation-and-conflict-error-in-scim-provisioning-process
branch
from
1aafc87 to
48619a8
Compare
battermann
force-pushed
the
WPB-6577-on-prem-duplicate-user-creation-and-conflict-error-in-scim-provisioning-process
branch
from
c4a5470 to
d6fe6fd
Compare
fisx
reviewed
Mar 6, 2024
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
looks good! i have one actual change request, otherwise looks good! let me know if you want to discuss this.
| prop "insert/lookup" $ prop_insertLookup (Just $ show . void . extract) lower | ||
| prop "insert/insert" $ prop_insertInsert (Just $ show . void . extract) lower | ||
|
|
||
| -- FUTUREWORK: Add prop tests for missing operations |
Contributor
There was a problem hiding this comment.
have you given this a try? if not i can do that.
Contributor
Author
There was a problem hiding this comment.
You can go ahead, but maybe better in a separate PR.
| -- something went wrong while storing the user in brig | ||
| -- we can try clean up now, but if brig is down, we can't do much | ||
| -- maybe retrying the user creation in brig is also an option? | ||
| -- after clean up we rethrow the error so the handler returns the correct failure |
Contributor
There was a problem hiding this comment.
what about not rethrowing, but looking up the status again once or twice? that'd make for swifter cleanup, especially when the batch job only runs once a day.
Contributor
Author
There was a problem hiding this comment.
It only rethrows if deleteScimUser fails. AFAICT the deletion is synchronous.
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
fisx
approved these changes
Mar 6, 2024
battermann
deleted the
WPB-6577-on-prem-duplicate-user-creation-and-conflict-error-in-scim-provisioning-process
branch
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a description of the manual test approach, see comments of https://wearezeta.atlassian.net/browse/WPB-6577
Checklist
changelog.d