Refactor and test user event serialisation#3912
Merged
pcapriotti merged 10 commits intodevelopfrom Mar 18, 2024
Merged
Conversation
pcapriotti
force-pushed
the
pcapriotti/golden-events
branch
from
2c4e3c5 to
f8ebe3b
Compare
pcapriotti
force-pushed
the
pcapriotti/golden-events
branch
from
f8ebe3b to
74575a2
Compare
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/golden-events
branch
from
a14bfe4 to
8ec8577
Compare
battermann
approved these changes
Mar 15, 2024
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
I would request to remove the empty file. The rest is just opinion and looks good otherwise. Approved in advance.
These JSON files were generated using the old serialisation code.
pcapriotti
force-pushed
the
pcapriotti/golden-events
branch
from
8ec8577 to
d7fcfdc
Compare
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the ad-hoc serialisation code for user event with schema-profunctor instances, like everything else, and introduces golden tests for them. The JSON golden files were generated using the old code to ensure this refactoring hasn't changed anything.
https://wearezeta.atlassian.net/browse/WPB-6892
Checklist
changelog.d