[WPB-6144] Don't remove MLS clients from a 1-1 conversation#3906
Merged
mdimjasevic merged 2 commits intodevelopfrom Feb 29, 2024
Merged
[WPB-6144] Don't remove MLS clients from a 1-1 conversation#3906mdimjasevic merged 2 commits intodevelopfrom
mdimjasevic merged 2 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
stefanwire
approved these changes
Feb 29, 2024
mdimjasevic
pushed a commit
that referenced
this pull request
Feb 29, 2024
mdimjasevic
pushed a commit
that referenced
this pull request
Mar 5, 2024
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of PR #3889, we used to remove MLS clients from a 1-to-1 conversation only on the backend side (i.e., not updating the group state). However, that's problematic as the state of the group on the backend side and on the client side is out of sync. This PR changes that by not removing the clients from the conversation; only the user is removed.
This PR adds no new tests, but it does rely on the
Test.MLS.One2One.testMLSOne2OneBlockedAfterConnectedtest from PR #3889.Tracked by https://wearezeta.atlassian.net/browse/WPB-6144.
Checklist
changelog.d