Skip to content

gundeck: set request id in request env#3903

Merged
supersven merged 3 commits intodevelopfrom
sventennie/gundeck-set-requestId-in-request-env
Feb 27, 2024
Merged

gundeck: set request id in request env#3903
supersven merged 3 commits intodevelopfrom
sventennie/gundeck-set-requestId-in-request-env

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Feb 26, 2024

The request id was missing in the Env. This led to "N/A" being logged.

I've deployed the gundeck Docker image of this branch on a test system (sven-test) and have seen that request IDs are being logged for queries where this didn't work before.

Ticket: https://wearezeta.atlassian.net/browse/WPB-6815

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

This has been missing, leading to "N/A" being logged instead of the
request ID.
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 26, 2024
@supersven supersven marked this pull request as ready for review February 26, 2024 17:14
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supersven supersven merged commit 21cc553 into develop Feb 27, 2024
@supersven supersven deleted the sventennie/gundeck-set-requestId-in-request-env branch February 27, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants