Merged
Conversation
Renaming by introducing new parameters just leads to more confusion.
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/gundeck-push_user-inconsistency
branch
from
4c523f0 to
425911a
Compare
supersven
changed the title
The env part can include '-' characters as well.
Hoping that the parser bug was the only cause for this check to fail.
We only want to log the value, not the containing data structure.
supersven
force-pushed
the
sventennie/gundeck-push_user-inconsistency
branch
from
4cb91f1 to
23bb40a
Compare
Just to check the variations.
supersven
changed the title
smatting
approved these changes
Feb 23, 2024
Contributor
smatting
left a comment
smatting
left a comment
There was a problem hiding this comment.
LGTM! 👍 for the unit tests covering both cases
akshaymankar
pushed a commit
that referenced
this pull request
Mar 6, 2024
This commit contains two things: 1. Add fields to the log message such that mismatches between stored and app-provided data become more obvious. 2. Fix an AWS SNS Endpoint parsing bug: We parsed the environment up to the first dash. But, environment names may contain dashes themselves, thus we must accumulate them up to the last dash.
akshaymankar
added a commit
that referenced
this pull request
Mar 11, 2024
This commit contains two things: 1. Add fields to the log message such that mismatches between stored and app-provided data become more obvious. 2. Fix an AWS SNS Endpoint parsing bug: We parsed the environment up to the first dash. But, environment names may contain dashes themselves, thus we must accumulate them up to the last dash. Backports #3894 Co-authored-by: Sven Tennie <sven.tennie@wire.com>
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two things:
Tickets:
Checklist
changelog.d