Skip to content

update annotation key for k8s 1.27+ #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitsagtani97 merged 3 commits into from
Feb 7, 2024
Merged

update annotation key for k8s 1.27+ #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81b19c8
update annotation key for k8s 1.27+
amitsagtani97 Feb 7, 2024
b184d5c
add changelog
amitsagtani97 Feb 7, 2024
c89e478
add backward compatability
amitsagtani97 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5-internal/update-k8s-annotation-for-topology-aware-routing
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
updated annotation for enabling Topology Aware Routing to service.kubernetes.io/topology-mode for k8s 1.27+
4 changes: 4 additions & 0 deletions charts/background-worker/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/backoffice/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/brig/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/cannon/templates/headless-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
# This is what makes it a Headless Service
Expand Down
4 changes: 4 additions & 0 deletions charts/cannon/templates/nginz-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
{{- if .Values.service.nginz.externalDNS.enabled }}
external-dns.alpha.kubernetes.io/ttl: {{ .Values.service.nginz.externalDNS.ttl | quote }}
external-dns.alpha.kubernetes.io/hostname: {{ required "Please provide .service.nginz.hostname when .service.nginz.enabled and .service.nginz.externalDNS.enabled are True" .Values.service.nginz.hostname | quote }}
Expand Down
4 changes: 4 additions & 0 deletions charts/cargohold/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/federator/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/galley/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/gundeck/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/legalhold/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ kind: Service
metadata:
name: "{{ .Release.Name }}-hold"
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
selector:
Expand Down
4 changes: 4 additions & 0 deletions charts/nginz/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/proxy/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down
4 changes: 4 additions & 0 deletions charts/spar/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
annotations:
{{- if ge (.Capabilities.KubeVersion.Minor|int) 26 }}
service.kubernetes.io/topology-mode: Auto
{{- else }}
service.kubernetes.io/topology-aware-hints: auto
{{- end }}
spec:
type: ClusterIP
ports:
Expand Down