Closed
Conversation
zebot
added
the
ok-to-test
smatting
requested changes
Jan 5, 2024
Contributor
smatting
left a comment
smatting
left a comment
There was a problem hiding this comment.
git blame leads me to #3749, specifically this comment https://github.com/wireapp/wire-server/pull/3749/files#diff-02ec43b3da1fa3f480f864ab97c43eeefe39e6e0487f245a1a5672f0282e10e7R112
Contributor
Author
|
ah, ok. makes kinda sense... sorry for the noise. |
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5803
We should either support this extension in both /integration and everywhere else, or nowhere. I'm very much in favor of "everywhere". Note that the extension allows for the old and the new syntax.
(I'm also curious: why was it disabled?)
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d