hack: Make tests pass by increasing http2-max-requests in the ingress controller#3787
Closed
akshaymankar wants to merge 1 commit intodevelopfrom
Closed
hack: Make tests pass by increasing http2-max-requests in the ingress controller#3787akshaymankar wants to merge 1 commit intodevelopfrom
akshaymankar wants to merge 1 commit intodevelopfrom
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
fed-nginx-keepalive
branch
from
25f70b1 to
59c89b8
Compare
akshaymankar
changed the title
… controller Workaround for: kazu-yamamoto/http2#102
akshaymankar
force-pushed
the
fed-nginx-keepalive
branch
from
59c89b8 to
539e1af
Compare
akshaymankar
changed the title
mdimjasevic
approved these changes
Dec 19, 2023
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
I know nothing about YAML templating, but why is the limit in one place in quotes and not in the other?
Member
Author
|
superseded by #3789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5934
Workaround for: kazu-yamamoto/http2#102
Checklist
Add a new entry in an appropriate subdirectory ofNo changelog.changelog.d