Skip to content

WPB-4887 increased ingress payload size from 256k to 512k #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
battermann merged 3 commits into from
Nov 30, 2023
Merged

WPB-4887 increased ingress payload size from 256k to 512k #3756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
655dbf3
increase client max body size
battermann Nov 29, 2023
69af72c
changelog
battermann Nov 29, 2023
bb4d29b
added comment
battermann Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5-internal/WPB-4887
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Increased ingress payload size from 256k to 512k
5 changes: 4 additions & 1 deletion charts/nginz/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ nginx_conf:
- /search/top
- /search/common

default_client_max_body_size: "256k"
# `default_client_max_body_size` is increased from 256k to 512k because
# client requests like listing users, conversations, filling or getting prekeys and other various MLS requests
# apparently may have bodies larger than 256k.
default_client_max_body_size: "512k"

@supersven supersven Nov 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment how this "magic number" was calculated would be great (though not mandatory.) If I remember this correctly, there was some specific request for a specific amount of group members? 🤔

rate_limit_reqs_per_user: "30r/s"
rate_limit_reqs_per_addr: "15r/m"

Expand Down