Modify federation diagram to include rabbitmq: updating the diagram and the source file#3739
Merged
arthurwolf merged 2 commits intodevelopfrom Jan 31, 2024
Merged
Conversation
zebot
added
the
ok-to-test
akshaymankar
requested changes
Nov 23, 2023
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Few incorrect things:
- Federator doesn't talk to rabbitmq, brig and galley do.
- Notification pusher talks to federator, it never talks outside the box.
- Cargohold is missing from this. It talks to federator and federator talks to it just like brig and galley. It doesn't talk to rabbitmq.
Contributor
Author
|
preview of latest version after two rounds of Akshay comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see wpb-3933
Checklist
changelog.d