Avoid generating client IDs with leading zeros#3709
Closed
pcapriotti wants to merge 2 commits intodevelopfrom
Closed
Avoid generating client IDs with leading zeros#3709pcapriotti wants to merge 2 commits intodevelopfrom
pcapriotti wants to merge 2 commits intodevelopfrom
Conversation
Leading zeros in client IDs expose an issue with the protobuf messaging API, since there client IDs are represented as uint64. This commit works around th eissue by removing any leading zeros when generating a new client ID.
zebot
added
the
ok-to-test
Co-authored-by: Mango The Fourth <40720523+MangoIV@users.noreply.github.com>
mdimjasevic
approved these changes
Nov 13, 2023
Contributor
Author
|
Superseded by #3713. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leading zeros in client IDs expose an issue with the protobuf messaging API, since there client IDs are represented as uint64. This commit works around th eissue by removing any leading zeros when generating a new client ID.
Checklist
changelog.d