Skip to content

Hotfix: Fixing how mls-test-cli is called #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supersven merged 2 commits into from
Nov 6, 2023
Merged

Hotfix: Fixing how mls-test-cli is called #3690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c012d
Hotfix: Fixing how mls-test-cli is called
lepsa Nov 3, 2023
404d682
WPB-5330: Removing more command args that are upsetting mls-test-cli
lepsa Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/WPB-5330
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Updating tests to fix an issue calling `mls-test-cli`
2 changes: 1 addition & 1 deletion integration/test/MLS/Util.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ createApplicationMessage cid messageContent = do
message <-
mlscli
cid
["message", "--group-in", "<group-in>", messageContent, "--group-out", "<group-out>"]
["message", "--group", "<group-in>", messageContent]
Nothing

pure
Expand Down
2 changes: 1 addition & 1 deletion libs/wire-api/test/unit/Test/Wire/API/MLS.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ testParseApplication = do
msgData <- withSystemTempDirectory "mls" $ \tmp -> do
void $ spawn (cli qcid tmp ["init", qcid]) Nothing
groupJSON <- spawn (cli qcid tmp ["group", "create", "Zm9v"]) Nothing
spawn (cli qcid tmp ["message", "--group-in", "-", "hello"]) (Just groupJSON)
spawn (cli qcid tmp ["message", "--group", "-", "hello"]) (Just groupJSON)

msg <- case decodeMLS' @Message msgData of
Left err -> assertFailure (T.unpack err)
Expand Down
2 changes: 1 addition & 1 deletion services/galley/test/integration/API/MLS/Util.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ createApplicationMessage cid messageContent = do
message <-
mlscli
cid
["message", "--group-in", "<group-in>", messageContent, "--group-out", "<group-out>"]
["message", "--group", "<group-in>", messageContent]
Nothing

pure $
Expand Down