Skip to content

wire-api: Remove explicit dependency on the pretty package #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaymankar merged 1 commit into from
Oct 16, 2023
Merged

wire-api: Remove explicit dependency on the pretty package #3651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libs/wire-api/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
, openapi3
, pem
, polysemy
, pretty
, process
, proto-lens
, protobuf
Expand Down Expand Up @@ -235,7 +234,6 @@ mkDerivation {
metrics-wai
openapi3
pem
pretty
process
proto-lens
QuickCheck
Expand Down
5 changes: 2 additions & 3 deletions libs/wire-api/test/golden/Test/Wire/API/Golden/Runner.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,11 @@ import Data.ByteString qualified as ByteString
import Data.ByteString.Lazy qualified as LBS
import Data.ProtoLens.Encoding (decodeMessage, encodeMessage)
import Data.ProtoLens.Message (Message)
import Data.ProtoLens.TextFormat (pprintMessage, readMessage)
import Data.ProtoLens.TextFormat (readMessage, showMessage)
import Data.Text.Lazy.IO qualified as LText
import Imports
import Test.Tasty (TestTree)
import Test.Tasty.HUnit
import Text.PrettyPrint (render)
import Type.Reflection (typeRep)
import Wire.API.ServantProto

Expand Down Expand Up @@ -93,7 +92,7 @@ protoTestObject ::
protoTestObject obj path = do
let actual = toProto obj
msg <- assertRight (decodeMessage @m actual)
let pretty = render (pprintMessage msg)
let pretty = showMessage msg
dir = "test/golden"
fullPath = dir <> "/" <> path
createDirectoryIfMissing True dir
Expand Down
1 change: 0 additions & 1 deletion libs/wire-api/wire-api.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ test-suite wire-api-golden-tests
, iso639
, lens
, pem
, pretty
, proto-lens
, tasty
, tasty-hunit
Expand Down