[WPB-4928] Stop using Servant client to enqueue federation notifications#3647
Merged
mdimjasevic merged 10 commits intodevelopfrom Oct 20, 2023
Merged
[WPB-4928] Stop using Servant client to enqueue federation notifications#3647mdimjasevic merged 10 commits intodevelopfrom
mdimjasevic merged 10 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
wpb-4928/notification-endpoints
branch
4 times, most recently
from
808050d to
9aadc6e
Compare
mdimjasevic
force-pushed
the
wpb-4928/notification-endpoints
branch
2 times, most recently
from
9e7288d to
210d643
Compare
mdimjasevic
force-pushed
the
wpb-4928/notification-endpoints
branch
from
210d643 to
0ee2a6d
Compare
mdimjasevic
force-pushed
the
wpb-4928/notification-endpoints
branch
from
0ee2a6d to
fbc0ea1
Compare
mdimjasevic
changed the title
mdimjasevic
commented
Oct 20, 2023
| m ~ FedQueueClient comp | ||
| forall tag api. | ||
| ( HasNotificationEndpoint tag, | ||
| -- api ~ NotificationAPI tag (NotificationComponent tag), |
Contributor
Author
There was a problem hiding this comment.
When I include this constraint, I get an error about the non-injectivity of a type family and I don't know how to fix it.
battermann
approved these changes
Oct 20, 2023
Contributor
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
LGTM overall, but I don't know about the non-injectivity error either.
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops using the Servant client to enqueue federation notifications. It also reorganises the federation API notification endpoints such that they are separated more from the synchronous endpoints. The notification endpoints rely on a type alias that always has
EmptyResponseas the response type.Tracked by https://wearezeta.atlassian.net/browse/WPB-4928.
Checklist
changelog.d