kube-integration-teardown: Ignore failures in helmfile destroy#3645
Merged
akshaymankar merged 1 commit intodevelopfrom Oct 17, 2023
Merged
kube-integration-teardown: Ignore failures in helmfile destroy#3645akshaymankar merged 1 commit intodevelopfrom
helmfile destroy#3645akshaymankar merged 1 commit intodevelopfrom
Conversation
This can happen due to some credentials being missing, the steps afterwards delete the whole namespace anyway. Also in this commit: Use 1 kubectl command to delete both namespaces, its faster like this because kubectl deletes them in parallel and kubeneretes can destroy resources inside in parallel.
zebot
added
the
ok-to-test
smatting
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen due to some credentials being missing, the steps afterwards delete the whole namespace anyway.
Also in this commit:
Use 1 kubectl command to delete both namespaces, its faster like this because kubectl deletes them in parallel and kubeneretes can destroy resources inside in parallel.
Checklist
Add a new entry in an appropriate subdirectory ofNo changelog.changelog.d