Conversation
MangoIV
changed the title
zebot
added
the
ok-to-test
MangoIV
force-pushed
the
mangoiv/conversation-member-leave-reason
branch
from
0184727 to
3d33ba7
Compare
MangoIV
force-pushed
the
mangoiv/conversation-member-leave-reason
branch
from
4535d7e to
ba9d75b
Compare
MangoIV
force-pushed
the
mangoiv/conversation-member-leave-reason
branch
from
557e8b1 to
013d3a4
Compare
pcapriotti
approved these changes
Oct 13, 2023
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good to me. However, it seems the "user deleted" and "user removed from team" reasons are conflated into one. That's probably fine, but maybe they should both be called "user deleted" rather than removed from team.
Minor comments follow.
Contributor
Author
So I will change it to "user deleted"? Or should I add another reason? I tried to tightly cohere with the ticket. |
- remove leftovers - s/EdReasonRemovedFromTeam/EdReasonDeleted - s/removed-from-team/user-deleted
Contributor
Author
|
For transparency: it was internally decide to rename to field to something more appropriate. |
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-4547
Checklist
changelog.d