[feat] improve type safety for Named, servantify brig internal route#3634
Merged
[feat] improve type safety for Named, servantify brig internal route#3634
Conversation
zebot
added
the
ok-to-test
MangoIV
force-pushed
the
mangoiv/servantify/brig-team-api
branch
2 times, most recently
from
cc3e290 to
f4814d2
Compare
elland
reviewed
Oct 9, 2023
Contributor
elland
left a comment
elland
left a comment
There was a problem hiding this comment.
How do you feel about moving the api handler definitions to the same file where we define the routes?
Contributor
Author
@elland the file I would move to is already quite large and the Maybe also consider moving the API definition itself to |
MangoIV
commented
Oct 9, 2023
MangoIV
force-pushed
the
mangoiv/servantify/brig-team-api
branch
2 times, most recently
from
293b6f6 to
5174695
Compare
MangoIV
force-pushed
the
mangoiv/servantify/brig-team-api
branch
from
8d446af to
5174695
Compare
elland
approved these changes
Oct 9, 2023
- improve type safety of Named by making it possible to rule out weakly typed arguments to the type (e.g. Type) - servantify the internal route for querying the teams API for servant
- add documentation of `Named` changes - s/UnSuspendTeam/UnsuspendTeam
MangoIV
force-pushed
the
mangoiv/servantify/brig-team-api
branch
from
5174695 to
b9ced29
Compare
Contributor
Author
|
finally the tests have passed! |
This was referenced Oct 19, 2023
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-1224
Checklist
changelog.d