WPB-5017: Adding a test config file to the PR guidelines.#3624
Merged
fisx merged 4 commits intowireapp:developfrom Oct 16, 2023
Merged
WPB-5017: Adding a test config file to the PR guidelines.#3624fisx merged 4 commits intowireapp:developfrom
fisx merged 4 commits intowireapp:developfrom
Conversation
fisx
requested changes
Sep 29, 2023
|
|
||
| * [ ] The parser under `services/brig/src/Brig/Options.hs` | ||
| * [ ] The integration test config: `services/brig/brig.integration.yaml` | ||
| * [ ] The integration test config: `services/brig/brig.integration.yaml` and `charts/cargohold/templates/tests/configmap.yaml` |
Contributor
There was a problem hiding this comment.
ah, wait, this was already documented, but you have to read the context carefully. this list is an example for the context where you made changes to brig. for cargohold, most items in this list will change.
do you have a suggestion how to make this more clear? maybe introduce variables $Service and $service to use in the list instead of brig?
Contributor
Author
There was a problem hiding this comment.
Variables would work, I think. I'll sit with this a bit and see what I can come up with.
lepsa
changed the title
pcapriotti
approved these changes
Oct 12, 2023
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
This is fine, but you could also add the item to the previous list, and simply use brig instead of $SERVICE, continuing the example.
fisx
approved these changes
Oct 16, 2023
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adding a testing config file to the PR guidelines.
Checklist
changelog.d