Merged
Conversation
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/mls-message-notif-bug
branch
2 times, most recently
from
b1eadf7 to
584f2dc
Compare
smatting
requested changes
Sep 29, 2023
pcapriotti
force-pushed
the
pcapriotti/mls-message-notif-bug
branch
2 times, most recently
from
c567483 to
fb984ea
Compare
pcapriotti
force-pushed
the
pcapriotti/mls-message-notif-bug
branch
from
7337774 to
a8160a2
Compare
Reorganise remote MLS message recipients by user, so that notifications can be more easily reconstructed on the receiving side.
pcapriotti
force-pushed
the
pcapriotti/mls-message-notif-bug
branch
from
a8160a2 to
2faadcf
Compare
mdimjasevic
approved these changes
Oct 13, 2023
This was referenced Oct 19, 2023
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-3867
This PR fixes a bug where some clients do not see MLS message notifications when fetching them with a
clientquery parameter. The problem is that MLS message notifications are sent to gundeck as a single push, which will in general contain differentRecipientobjects for different clients of the same users. This makes the entries conflict with one another in cassandra, and therefore only one client ends up being stored in the database.The fix here is "condensing" consecutiveRecipientitems relating to the same user by joining them together into a singleRecipientobject. This works because because recipient lists are generated by user.This is now fixed by overloading
newMessagePushso that it can work both with simple(User, Client)pairs - employed by Proteus messaging code - and with actualRecipientobjects (i.e. one user, multiple clients) - used by MLS.TODO
Checklist
changelog.d