Skip to content

Comments

[WPB-4556] document internal user creation#3596

Merged
fisx merged 4 commits intodevelopfrom
WPB-4556-document-internal-user-creation
Sep 21, 2023
Merged

[WPB-4556] document internal user creation#3596
fisx merged 4 commits intodevelopfrom
WPB-4556-document-internal-user-creation

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Sep 21, 2023

https://wearezeta.atlassian.net/browse/WPB-4556

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 21, 2023
@fisx fisx requested a review from paulwire September 21, 2023 09:35
Copy link

@paulwire paulwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, regarding the change in create_test_team_admins.sh

their teams.

This is the way to create teams if you have set
'setRestrictUserCreation' to false in your 'values.yaml'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be "setRestrictUserCreation" to true - or am I confused here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. you're right, thanks! aea091d

@fisx fisx requested a review from paulwire September 21, 2023 10:54
@fisx fisx merged commit 5be6b37 into develop Sep 21, 2023
@fisx fisx deleted the WPB-4556-document-internal-user-creation branch September 21, 2023 11:32
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants