Skip to content

Comments

[WPB-3664] Port changes from develop to mandarin#3591

Merged
mdimjasevic merged 1 commit intomandarinfrom
wpb-3664/cherry-pick-from-develop-to-mandarin
Sep 20, 2023
Merged

[WPB-3664] Port changes from develop to mandarin#3591
mdimjasevic merged 1 commit intomandarinfrom
wpb-3664/cherry-pick-from-develop-to-mandarin

Conversation

@mdimjasevic
Copy link
Contributor

This ports the PR #3537 from develop to mandarin.

Tracked by https://wearezeta.atlassian.net/browse/WPB-3664.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic changed the base branch from develop to mandarin September 20, 2023 10:41
@mdimjasevic mdimjasevic marked this pull request as ready for review September 20, 2023 10:48
@mdimjasevic mdimjasevic marked this pull request as draft September 20, 2023 10:48
@mdimjasevic mdimjasevic added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 20, 2023
…m conversation when reachable again (#3537)

* Formatting

* Test utilities for changing a conv name

* Add a test confirming the bug report

* An action to enqueue notifications concurrently

* Enqueue member removal notification for remotes

* Add a changelog

* Test case formatting

* Migrate test roleUpdateWithRemotesUnavailable

* Migrate test putReceiptModeWithRemotesOk

* Migrate test putReceiptModeWithRemotesUnavailable

* Migrate test testRoleUpdateWithRemotesOk

* Migrate test roleUpdateRemoteMember

* Migrate test putQualifiedConvRenameWithRemotesUnavailable

This one is already covered by testSynchroniseUserRemovalNotification

* Migrate test putQualifiedConvRenameWithRemotesOk

* Migrate test deleteLocalMemberConvLocalQualifiedOk

* Migrate test deleteRemoteMemberConvLocalQualifiedOk

* Migrate test deleteUnavailableRemoteMemberConvLocalQualifiedOk

* Add the copyright header to a test module

* Move a test utility (allPreds)

* Test utility: create a team with members

* Migrate test testAccessUpdateGuestRemoved

* Migrate test messageTimerChangeWithRemotes

* Migrate test messageTimerUnavailableRemotes

* Migrate test testAccessUpdateGuestRemovedRemotesUnavailable

* Migrate test accessUpdateWithRemotes

* Migrate test testAddRemoteMember

* Migrate test testDeleteTeamConversationWithRemoteMembers

* Migrate test testDeleteTeamConversationWithUnavailableRemoteMembers

* Move a test utility (assertLeaveNotification)

* Migrate test "POST /federation/leave-conversation : Success"

* Migrate test "POST /federation/on-user-deleted-conversations : Remove deleted remote user from local conversations"

* Migrate test updateConversationByRemoteAdmin

* Tests: support giving a role when adding

* Use cannon API for notifications when possible

* Use startDynamicBackends when possible

* Fix assertion

* Migrate test testAddRemoteUsersToLocalConv

* Test add member endpoint at version 1

* Add return value to enqueueNotification

* Use cannon assertions in offline backends test

* Check that remote notifications are received

* Test removal of users from unreachable backends

* Use correct domains for default backends

Taking the domains in the `backendA` and `backendB` resources only works
locally.

* fixup! Use cannon assertions in offline backends test

---------

Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
Co-authored-by: Akshay Mankar <akshay@wire.com>
@mdimjasevic mdimjasevic force-pushed the wpb-3664/cherry-pick-from-develop-to-mandarin branch from e0e56ab to 7042997 Compare September 20, 2023 11:05
@mdimjasevic mdimjasevic marked this pull request as ready for review September 20, 2023 11:05
@mdimjasevic mdimjasevic merged commit ef8633b into mandarin Sep 20, 2023
@mdimjasevic mdimjasevic deleted the wpb-3664/cherry-pick-from-develop-to-mandarin branch September 20, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants