Fix federationStrategy 'allowAll'

[akshaymankar]

https://wearezeta.atlassian.net/browse/WPB-3796

Supersedes #3526

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[fisx]

i'm also ok with doing this in integration.cabal...

[akshaymankar]

Please create a PR then.

[fisx]

this isn't called anywhere, but neither is it translated into /integration. i think running this won't pass for the same reason testHandleLookup fails?

[akshaymankar]

Deleted it now.
The test already existed in the new test suite:

wire-server/integration/test/Test/Brig.hs

Lines 144 to 160 in 1c6f746

	testRemoteUserSearch :: HasCallStack => App ()
	testRemoteUserSearch = do
	let overrides =
	setField "optSettings.setFederationStrategy" "allowDynamic"
	>=> setField "optSettings.setFederationDomainConfigsUpdateFreq" (Aeson.Number 1)
	startDynamicBackends [def {brigCfg = overrides}, def {brigCfg = overrides}] $ \dynDomains -> do
	domains@[d1, d2] <- pure dynDomains
	connectAllDomainsAndWaitToSync 1 domains
	[u1, u2] <- createAndConnectUsers [d1, d2]
	Internal.refreshIndex d2
	uidD2 <- objId u2
	bindResponse (Public.searchContacts u1 (u2 %. "name") d2) $ \resp -> do
	resp.status `shouldMatchInt` 200
	docs <- resp.json %. "documents" >>= asList
	case docs of
	[] -> assertFailure "Expected a non empty result, but got an empty one"
	doc : _ -> doc %. "id" `shouldMatch` uidD2

[fisx]

did you remove this search intentionally?

[akshaymankar]

Yes, the test is supposed to show that federation works in dynamic backends. Using search here is just making the test more complicated.