Refactor data structures in spar related to user-identifying information#3563
Draft
fisx wants to merge 100 commits intowireapp:developfrom
Draft
Refactor data structures in spar related to user-identifying information#3563fisx wants to merge 100 commits intowireapp:developfrom
fisx wants to merge 100 commits intowireapp:developfrom
Conversation
…esentations Creating a new generic data structure for holding valid combinations of identifiers. It is intended to be used with `Const ()` and `Identity` to represent existence and non-existence of a given identity option. A tag and type family, modeled after `ConversationAction` is used to limit the options of the above data structure to only those that are deemed valid in some sense.
Added my thoughts and questions for fisx.
the way this works is as follows: we have a few fields in record types like User, NewUser, NewUserRaw that contribute to the `UserIdentity` type. all those fields are collected here as-is, and then parsed further to make sure that they do not contain any logic errors (like uauth_id, but on team_id). my earlier change to this type was based on the inlining of the fields from UAuthId into the User record. but i realized i don't like inlining. i think it makes things complicated to parse both for machines and humans for no measurable benefit. so, there are 4 components: phone, email, the legacy sso_id field, and the new uauth_id field.
2 tasks
fisx
added
the
ok-to-test
echoes-hq
bot
added
echoes: product-roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-1583
https://wearezeta.atlassian.net/browse/WPB-3530
Checklist
changelog.d