Support post-quantum MLS ciphersuite#3454
Merged
pcapriotti merged 18 commits intomlsfrom Aug 24, 2023
Merged
Conversation
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/mls-kyber-ciphersuite
branch
3 times, most recently
from
10ffa51 to
4809c8d
Compare
pcapriotti
force-pushed
the
pcapriotti/mls-kyber-ciphersuite
branch
2 times, most recently
from
93dd16c to
4ce9a72
Compare
smatting
reviewed
Aug 14, 2023
smatting
reviewed
Aug 14, 2023
smatting
approved these changes
Aug 14, 2023
pcapriotti
force-pushed
the
pcapriotti/mls-kyber-ciphersuite
branch
4 times, most recently
from
3615452 to
034eeca
Compare
Instead of crafting an unsupported proposal in the haskell code, we now use mls-test-cli to create a `ReInit` proposal.
When constructing the query parameter corresponding to a ciphersuite in an internal API, use the `ToHttpApiData` instance instead of converting the ciphersuite into a bytestring manually.
pcapriotti
force-pushed
the
pcapriotti/mls-kyber-ciphersuite
branch
from
034eeca to
7932a1b
Compare
pcapriotti
added a commit
that referenced
this pull request
Sep 27, 2023
* Add hybrid Kyber ciphersuite * Fix ciphersuite tag parser * Change conversation ciphersuite on first commit * Save MLS keystore as part of a client's state * Move invalid epoch test to new suite * Rewrite unsupported proposal test Instead of crafting an unsupported proposal in the haskell code, we now use mls-test-cli to create a `ReInit` proposal. * Forbid bare proposals at epoch 0 * Do not crash on invalid subconversation entries * Index key packages by ciphersuite * Add ciphersuite parameter to some tests * Test key packages with multiple ciphersuites * Test key package upload with unsupported CS * Test commit with unsupported ciphersuite * Update mls-test-cli to pq branch * Add CHANGELOG entries * Remove unused dependency * Use `ToHttpApiData` instance of CipherSuite When constructing the query parameter corresponding to a ciphersuite in an internal API, use the `ToHttpApiData` instance instead of converting the ciphersuite into a bytestring manually. * Linter fixes
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for MLS ciphersuite
MLS_128_X25519Kyber768Draft00_AES128GCM_SHA256_Ed25519.https://wearezeta.atlassian.net/browse/WPB-2862
Checklist
changelog.d