Skip to content

Tweak changelog.#3384

Merged
fisx merged 5 commits intodevelopfrom
tweak-changelog
Jul 3, 2023
Merged

Tweak changelog.#3384
fisx merged 5 commits intodevelopfrom
tweak-changelog

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jun 28, 2023

The changelog for #3260 wasn't very exhaustive, here's an improved version.

@fisx fisx requested a review from akshaymankar June 28, 2023 20:47
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 28, 2023
Comment on lines 54 to 57
Once the upgrade has been deployed *and* table
`brig.federation_remotes` has been filled with the temporary contents
of `brig.config.optSettings.setFederationDomainConfigs`, it is safe to
remove the latter and the above lines from the federator config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which endpoint can be used to fill this table? Are there docs about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fisx and others added 2 commits July 3, 2023 11:32
Co-authored-by: Akshay Mankar <akshay@wire.com>
@fisx fisx requested a review from akshaymankar July 3, 2023 10:42
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fisx fisx merged commit 6f0c4e8 into develop Jul 3, 2023
@fisx fisx deleted the tweak-changelog branch July 3, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants