Avoid MLS messages in sender client's event stream#3379
Merged
stefanwire merged 4 commits intomlsfrom Jun 27, 2023
Merged
Conversation
zebot
added
the
ok-to-test
pcapriotti
approved these changes
Jun 26, 2023
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good. Although maybe it would be good to have a test that the sender client is indeed not receiving these messages. And maybe some comments for our future selves explaining that this behaviour is indeed pretty strange, but it's what the clients want.
pcapriotti
reviewed
Jun 27, 2023
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d