Skip to content

Comments

alter group ID serialisation#3353

Merged
stefanwire merged 1 commit intomlsfrom
sb/groupid-serialisation
Jun 15, 2023
Merged

alter group ID serialisation#3353
stefanwire merged 1 commit intomlsfrom
sb/groupid-serialisation

Conversation

@stefanwire
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@stefanwire stefanwire requested a review from pcapriotti June 14, 2023 14:12
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 14, 2023
@stefanwire stefanwire force-pushed the sb/groupid-serialisation branch from b014b28 to 7cce177 Compare June 14, 2023 14:24
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why is this in its own PR?

@stefanwire stefanwire force-pushed the WPB-1925 branch 2 times, most recently from 76f629b to ae21475 Compare June 15, 2023 09:54
Base automatically changed from WPB-1925 to mls June 15, 2023 10:31
- 16 bit version
- 16 bit conversation type
@stefanwire stefanwire force-pushed the sb/groupid-serialisation branch from 7cce177 to d2c0ae3 Compare June 15, 2023 10:37
@stefanwire stefanwire merged commit 8325c9b into mls Jun 15, 2023
@stefanwire stefanwire deleted the sb/groupid-serialisation branch June 15, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants