Use feature singletons in TeamFeatureStore#3308
Merged
pcapriotti merged 3 commits intodevelopfrom May 23, 2023
Merged
Conversation
This introduces a `FeatureSingleton` GADT, which is then used by the Cassandra interpretation of `TeamFeatureStore` to determine how to read and write into the database. Feature singletons avoids having to pass a database-specific constraint to the effect itself, and as a consequence makes it possible to remove the `db` type variable from all the code that uses the `TeamFeature` effect.
zebot
added
the
ok-to-test
smatting
approved these changes
May 23, 2023
smatting
approved these changes
May 23, 2023
smatting
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a
FeatureSingletonGADT, which is then used by the Cassandra interpretation ofTeamFeatureStoreto determine how to read and write into the database.Feature singletons avoids having to pass a database-specific constraint to the effect itself, and as a consequence makes it possible to remove the
dbtype variable from all the code that uses theTeamFeatureeffect.Checklist
changelog.d