Skip to content

fix: Flaky DPoP access token test #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
battermann merged 1 commit into from
May 17, 2023
Merged

fix: Flaky DPoP access token test #3302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/brig/test/integration/API/User/Client.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import qualified Data.Set as Set
import Data.String.Conversions (cs)
import Data.Text (replace)
import Data.Text.Ascii (AsciiChars (validate))
import Data.Time (addUTCTime)
import Data.Time.Clock.POSIX
import qualified Data.Vector as Vec
import Imports
Expand Down Expand Up @@ -1440,7 +1441,7 @@ testCreateAccessToken opts n brig = do
let claimsSet' =
emptyClaimsSet
& claimIat ?~ NumericDate now
& claimExp ?~ NumericDate now
& claimExp ?~ NumericDate (addUTCTime 10 now)
& claimNbf ?~ NumericDate now
& claimSub ?~ fromMaybe (error "invalid sub claim") ((clientIdentity :: Text) ^? stringOrUri)
& claimJti ?~ "6fc59e7f-b666-4ffc-b738-4f4760c884ca"
Expand All @@ -1451,7 +1452,7 @@ testCreateAccessToken opts n brig = do
Right signed -> do
let proof = Just $ Proof (cs signed)
response <- Util.createAccessTokenNginz n t cid proof
accessToken <- responseJsonError response
let accessToken = fromRight (error $ "failed to create token: " <> show response) $ responseJsonEither response
liftIO $ datrType accessToken @?= DPoP
where
signAccessToken :: DPoPClaimsSet -> IO (Either JWTError SignedJWT)
Expand Down