coturn: Add federation and DTLS support to Helm chart#3283
Merged
coturn: Add federation and DTLS support to Helm chart#3283
Conversation
This is mostly inspired by the restund Helm chart.
|
|
zebot
added
the
ok-to-test
jschaul
approved these changes
May 10, 2023
Member
jschaul
left a comment
jschaul
left a comment
There was a problem hiding this comment.
Minor comments; this is good to be merged once it's deemed fit for purpose. 🙂
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
The templating logic could be simplified by relying on default values.
2 tasks
- CA-file is mandatory to use federated certificate whitelisting - max-allocate-lifetime: Remove default value
Contributor
Author
|
@jschaul I'm merging it now. The federation related tests aren't finished. But, the chart changes seem to fulfill their purpose and I also checked it with Scott. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly inspired by the restund Helm chart.
Why is this a draft? Because, we haven't finished testing
coturnon dogfood environments and may need more changes.There's a related PR in
cailleach: https://github.com/zinfra/cailleach/pull/1648Checklist
changelog.d