Skip to content

Comments

Add subconversation ID to RemoteMLSMessage#3270

Merged
stefanwire merged 4 commits intomlsfrom
FS-1868
May 8, 2023
Merged

Add subconversation ID to RemoteMLSMessage#3270
stefanwire merged 4 commits intomlsfrom
FS-1868

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented May 4, 2023

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

See also #3271.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 4, 2023
@stefanwire stefanwire marked this pull request as ready for review May 8, 2023 08:00
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the new test should go into the new integration package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants