Skip to content

coturn helm chart: use a memory-backed mount#3220

Merged
supersven merged 1 commit intodevelopfrom
coturn-tmpfs-volume
Apr 6, 2023
Merged

coturn helm chart: use a memory-backed mount#3220
supersven merged 1 commit intodevelopfrom
coturn-tmpfs-volume

Conversation

@jschaul
Copy link
Member

@jschaul jschaul commented Apr 5, 2023

Add memory-backed mount /var/lib/coturn to store sqllite DB to improve performance, as described on https://github.com/wireapp/coturn/tree/master/docker/coturn#persistence

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

Add memory-backed mount /var/lib/coturn to store sqllite DB to improve performance, as described on https://github.com/wireapp/coturn/tree/master/docker/coturn#persistence
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 5, 2023
@flokli
Copy link
Contributor

flokli commented Apr 5, 2023

We are certain we don't need any of that state?

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschaul Well, I give you a conditional approval: If it doesn't turn out to be beneficial (no pun intended 😉 ), please roll the change back.

@supersven
Copy link
Contributor

We are certain we don't need any of that state?

@flokli , @jschaul , AFAIK the state was previously saved in the container itself. That's not very persistent, too... 😉 However, maybe, @jschaul can try to understand what the database's data is about and if it would be beneficial to keep it in a persistent db?

@supersven supersven merged commit 8bc4cea into develop Apr 6, 2023
@supersven supersven deleted the coturn-tmpfs-volume branch April 6, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments