Conversation
jschaul
left a comment
There was a problem hiding this comment.
Looks like it could almost work... minor comments inline.
| run_integration_tests "$package" | ||
| fi | ||
| done | ||
| run_integration_tests "stern" |
There was a problem hiding this comment.
above the path is hardcoded to ./services/$package, but stern is underneath "./tools"
There was a problem hiding this comment.
Yes, true, for some reason it works anyway, but I will try to fix this anyway.
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
| port: 8080 | ||
|
|
||
| stern: | ||
| host: stern |
There was a problem hiding this comment.
this is not correct, the k8s service is called backoffice. DNS to stern does not resolve.
please adjust names so they match actual objects. |
|
Now tests run, but fail. the integration executable and stern itself run in two different pods, so the hostname seems wrong somewhere. locally everything's on localhost, inside k8s that's not the case, so I think either config is incorrect or (more likely) the test setup is not reading the right values. |
fisx
left a comment
There was a problem hiding this comment.
it would have been nice to start in the new integration-tests package with this, but it's also nice to have this immediately! 👍
Checklist
changelog.d