Skip to content

Comments

Stern Integration Tests#3216

Merged
battermann merged 14 commits intodevelopfrom
battermann/stern-integration-tests
Apr 6, 2023
Merged

Stern Integration Tests#3216
battermann merged 14 commits intodevelopfrom
battermann/stern-integration-tests

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 4, 2023

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann changed the base branch from develop to battermann/fix-stern-internal-paths April 4, 2023 09:49
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 4, 2023
@battermann battermann changed the title Battermann/stern integration tests Stern Integration Tests Apr 4, 2023
Base automatically changed from battermann/fix-stern-internal-paths to develop April 4, 2023 11:21
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it could almost work... minor comments inline.

run_integration_tests "$package"
fi
done
run_integration_tests "stern"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above the path is hardcoded to ./services/$package, but stern is underneath "./tools"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, true, for some reason it works anyway, but I will try to fix this anyway.

battermann and others added 2 commits April 4, 2023 14:50
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
port: 8080

stern:
host: stern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct, the k8s service is called backoffice. DNS to stern does not resolve.

@jschaul
Copy link
Member

jschaul commented Apr 4, 2023

Warning  FailedMount  3s (x4 over 7s)  kubelet            MountVolume.SetUp failed for volume "stern-config" : configmap "stern" not found 

please adjust names so they match actual objects.

@jschaul
Copy link
Member

jschaul commented Apr 4, 2023

Now tests run, but fail.

the integration executable and stern itself run in two different pods, so the hostname seems wrong somewhere. locally everything's on localhost, inside k8s that's not the case, so I think either config is incorrect or (more likely) the test setup is not reading the right values.

Stern

  API tests

    GET /users/by-ids: FAIL

      Exception: HttpExceptionRequest Request {

        host                 = "0.0.0.0"

        port                 = 8080

        secure               = False

        requestHeaders       = []

        path                 = "users/by-ids"

        queryString          = "?ids=e593bf1f-9682-48bd-a619-e1616c7d36ae"

        method               = "GET"

        proxy                = Nothing

        rawBody              = False

        redirectCount        = 10

        responseTimeout      = ResponseTimeoutDefault

        requestVersion       = HTTP/1.1

      }

       (ConnectionFailure Network.Socket.connect: <socket: 73>: does not exist (Connection refused))

      Use -p '/GET \/users\/by-ids/' to rerun this test only.

    GET /teams/:id:    FAIL

      Exception: HttpExceptionRequest Request {

        host                 = "0.0.0.0"

        port                 = 8080

        secure               = False

        requestHeaders       = []

        path                 = "teams/dadc94df-e2b2-4006-91ba-343d6695e84c"

        queryString          = ""

        method               = "GET"

        proxy                = Nothing

        rawBody              = False

        redirectCount        = 10

        responseTimeout      = ResponseTimeoutDefault

        requestVersion       = HTTP/1.1

      }

       (ConnectionFailure Network.Socket.connect: <socket: 74>: does not exist (Connection refused))

      Use -p '/GET \/teams\/:id/' to rerun this test only.


2 out of 2 tests failed (2.54s)

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would have been nice to start in the new integration-tests package with this, but it's also nice to have this immediately! 👍

Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@battermann battermann marked this pull request as ready for review April 5, 2023 14:34
@battermann battermann merged commit 8a5843a into develop Apr 6, 2023
@battermann battermann deleted the battermann/stern-integration-tests branch April 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants