Skip to content

Comments

[SQSERVICES-1619] Tech Debt Remove Non Binding Teams Code#3213

Merged
battermann merged 6 commits intodevelopfrom
SQSERVICES-1619-be-tech-debt-remove-non-binding-teams-code-2
Apr 17, 2023
Merged

[SQSERVICES-1619] Tech Debt Remove Non Binding Teams Code#3213
battermann merged 6 commits intodevelopfrom
SQSERVICES-1619-be-tech-debt-remove-non-binding-teams-code-2

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 3, 2023

https://wearezeta.atlassian.net/browse/SQSERVICES-1619

First, remove the non-binding team endpoints from V4. The non-binding team code can be removed completely once V3 is not supported anymore.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 3, 2023
@battermann battermann marked this pull request as ready for review April 3, 2023 09:19
@battermann battermann requested a review from fisx April 3, 2023 09:19
@@ -0,0 +1 @@
Non-binding team endpoints are removed from API version V4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Non-binding team endpoints are removed from API version V4
Remove deprecated non-binding team endpoints from API version V4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this appears in the changelog, it is already in the past. So I prefer past tense or even better "have been removed" (present perfect progressive). But I will not hold my opinion very strongly. :)

"create-non-binding-team"
( Summary "Create a new non binding team"
-- FUTUREWORK: deprecated in https://github.com/wireapp/wire-server/pull/2607
:> Until 'V4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe still link the PR and/or ticket? not sure, maybe it's unnecessary noise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer less noise.

@fisx
Copy link
Contributor

fisx commented Apr 3, 2023

Hum, I think you also want to deprecate

-- FUTUREWORK: deprecated in https://github.com/wireapp/wire-server/pull/2607

If clients use it, it should be replaced by "get-team" (path "/team"); if nobody uses it, it should go away. (Feel free to overrule me, but if you do please document the history in swagger for future me. :)

Co-authored-by: fisx <mf@zerobuzz.net>
@battermann
Copy link
Contributor Author

Hum, I think you also want to deprecate

-- FUTUREWORK: deprecated in https://github.com/wireapp/wire-server/pull/2607

If clients use it, it should be replaced by "get-team" (path "/team"); if nobody uses it, it should go away. (Feel free to overrule me, but if you do please document the history in swagger for future me. :)

Ok, granted. :)

@battermann battermann merged commit 0b624b6 into develop Apr 17, 2023
@battermann battermann deleted the SQSERVICES-1619-be-tech-debt-remove-non-binding-teams-code-2 branch April 17, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants