Skip to content

Comments

Unclutter ormolu script#3193

Merged
fisx merged 5 commits intodevelopfrom
unclutter-ormolu-script
Mar 28, 2023
Merged

Unclutter ormolu script#3193
fisx merged 5 commits intodevelopfrom
unclutter-ormolu-script

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Mar 27, 2023

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
Copy link
Contributor Author

fisx commented Mar 27, 2023

$ git grep -Hn package-defaults.yaml | grep -v ^changelog.d/5-internal/unclutter-ormolu-script
libs/wire-api/test/golden/gentests.sh:183:readarray -t EXTS < <(sed -rn '/^default-extensions:/,$ { s/^- (.*)/\1/ }' ../../package-defaults.yaml)

I don't think we'll ever be able to call this script again without heavy rewriting work, so I think this is fine?

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 27, 2023
@fisx fisx requested a review from smatting March 28, 2023 09:54
@fisx fisx merged commit 2c319dd into develop Mar 28, 2023
@fisx fisx deleted the unclutter-ormolu-script branch March 28, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants