try recreating ARN when token exists in Cassandra#3162
Merged
stefanwire merged 5 commits intodevelopfrom Mar 21, 2023
Merged
Conversation
zebot
added
the
ok-to-test
stefanwire
force-pushed
the
SQPIT-1544/recreatearn
branch
from
a99d7e9 to
df004b8
Compare
supersven
approved these changes
Mar 17, 2023
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
LGTM 👍
There are now several nitpicking comments. Please feel free to solve them as are as you feel confident that they don't break anything. (I hope I only proposed things that don't.)
BTW, I see that most of the issues weren't introduced by you. You only touched / moved the code. Please feel free to decide how far you' like to apply the "boy scout" rule.
stefanwire
force-pushed
the
SQPIT-1544/recreatearn
branch
from
b68fa55 to
97f9e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d