inbucket Helm chart: TLS and basic authentication#3161
Merged
Conversation
zebot
added
the
ok-to-test
smatting
approved these changes
Mar 16, 2023
supersven
force-pushed
the
sventennie/inbucket-tls-ip-allowlisting
branch
from
a9f8707 to
6fad79a
Compare
lepsa
pushed a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
As discussed with QA and security: This adds TLS (HTTPS) and HTTP basic authentication to the inbucket Helm chart. (It was: No authentication, no HTTPS.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with QA and security: This adds TLS (HTTPS) and HTTP basic authentication to the
inbucketHelm chart. (It was: No authentication, no HTTPS.)I tried to separate the
cert-managerstuff ofnginx-ingress-servicefrom this chart, because this should really just be a help for testing and not interfere with production things.The branch name is a bit misleading, because we switched the goal from ip allow listing to basic authentication.
Checklist
changelog.d